Skip to content

Update CONTRIBUTING.md#4105

Draft
ashleney wants to merge 3 commits into
TerraFirmaGreg-Team:devfrom
ashleney:feat/contributing
Draft

Update CONTRIBUTING.md#4105
ashleney wants to merge 3 commits into
TerraFirmaGreg-Team:devfrom
ashleney:feat/contributing

Conversation

@ashleney
Copy link
Copy Markdown
Contributor

@ashleney ashleney commented May 23, 2026

No description provided.

Copy link
Copy Markdown
Member

@SakuraKitsurugi SakuraKitsurugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove the Russian part, just ask for someone else to update it later.

Copy link
Copy Markdown
Member

@Pyritie Pyritie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why you felt the need to completely remove all the formatting that the version used to have, Can you add it back? It went into more detail on some steps instead of just "clone the repo" which means nothing to people who are totally new, which this guide is supposed to be aimed at.

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
4. Test your changes by building your core jar, adding it to your instance and launching it.

**Проверка типов TypeScript:**
If you're using vscode, you may want to try [ProbeJs](https://marketplace.visualstudio.com/items/?itemName=Prunoideae.probejs) for kubejs changes (optional).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no guide on how to set up intellij to work with tfg-core

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use Intellij personally

@ashleney ashleney marked this pull request as draft May 23, 2026 23:48
@ashleney ashleney force-pushed the feat/contributing branch from 221887e to ebd5d1c Compare May 24, 2026 00:10
@ashleney ashleney force-pushed the feat/contributing branch from ebd5d1c to 7f54d23 Compare May 24, 2026 00:21
@ashleney ashleney marked this pull request as ready for review May 24, 2026 00:40
@ashleney ashleney marked this pull request as draft May 24, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants